Fix incorrect documentation in markdown files#92
Open
JoshSalway wants to merge 2 commits intolaravel:mainfrom
Open
Fix incorrect documentation in markdown files#92JoshSalway wants to merge 2 commits intolaravel:mainfrom
JoshSalway wants to merge 2 commits intolaravel:mainfrom
Conversation
…move redundant COMMANDS_SUMMARY.md - AI_BEST_PRACTICES.md: Replace incorrect Illuminate\Http\Client\RequestException with Saloon\Exceptions\Request\RequestException, replace CloudClient with Connector, fix $e->response->status()/json() to $e->getResponse()->status()/json() - README.md: Add missing application:delete command, fix environment:variables description to reflect append/set/replace capabilities - Delete COMMANDS_SUMMARY.md as it is incomplete and redundant with README.md Closes laravel#91 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Documents 11 new commands added by our PRs: - environment:start, environment:stop (laravel#70) - environment:metrics (laravel#72) - deployment:logs (laravel#71) - cache:metrics, database-cluster:metrics (laravel#72) - websocket-cluster:metrics, websocket-application:metrics (laravel#72) - env:pull, env:push (laravel#81) - use (laravel#80) Also updated environment:variables description to include 'delete' action. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect documentation and adds missing commands to README.
Closes #91
Changes
AI_BEST_PRACTICES.md — 7 incorrect references fixed
CloudClientConnector(App\Client\Connector)Illuminate\Http\Client\RequestExceptionSaloon\Exceptions\Request\RequestException$e->response->status()$e->getResponse()->status()$e->response->json()$e->getResponse()->json()The
Illuminate\Http\Client\RequestExceptionclass does not exist in vendor — this CLI uses Saloon, not Laravel HTTP client. TheCloudClientclass has never existed in the codebase.COMMANDS_SUMMARY.md — deleted
Redundant with README.md which already has a comprehensive command reference. The file was incomplete and outdated.
README.md — 2 fixes + 12 new commands documented
Fixes:
application:deleteto Applications tableenvironment:variablesdescription: "Replace env vars from a file" → "Manage environment variables (append, set, replace, delete)"New commands added (from open PRs):
cloud environment:startcloud environment:stopcloud environment:metricscloud deployment:logscloud database-cluster:metricscloud cache:metricscloud websocket-cluster:metricscloud websocket-application:metricscloud env:pullcloud env:pushcloud useREADME now documents all 97 commands (86 existing + 11 new).
Note
The 11 new commands are from open PRs that have not yet been merged. If those PRs are not accepted, the corresponding README entries should be removed. Each entry references its source PR for traceability.
Generated with Claude Code