feat: add environment:variables delete action and metrics commands#72
Open
JoshSalway wants to merge 1 commit intolaravel:mainfrom
Open
feat: add environment:variables delete action and metrics commands#72JoshSalway wants to merge 1 commit intolaravel:mainfrom
JoshSalway wants to merge 1 commit intolaravel:mainfrom
Conversation
- Add `delete` action to `environment:variables` command, accepting `--key` flag(s) to specify which variables to remove (laravel#67) - Add metrics commands for cache, database-cluster, environment, websocket-application, and websocket-cluster resources (laravel#68) - Create corresponding API request classes and resource methods - Add tests for all new functionality Closes laravel#67, laravel#68, laravel#69 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteaction to theenvironment:variablescommand, allowing users to remove environment variables by key via--action=delete --key=VAR_NAME --force(fixes Missing command: environment:variables --delete to remove individual variables #67)cache:metrics,database-cluster:metrics,environment:metrics,websocket-application:metrics,websocket-cluster:metrics(fixes Missing commands: metrics for cache, database cluster, environment, and websocket resources #68, fixes Epic: Complete API parity — missing commands for 11 API endpoints #69)DeleteEnvironmentVariablesRequest,Get*MetricsRequest) andmetrics()methods on each resource classDetails
Part 1:
environment:variables --deletedeleteaction in the interactive action selector--action=delete --key=VAR_NAME --force--keyflags to delete several variables at once--forcein non-interactive mode for safetyPart 2: Metrics commands
--json)*:getcommandsTest plan
./vendor/bin/pestpasses (39 tests, 40 assertions)./vendor/bin/phpstan analysepasses (0 errors)🤖 Generated with Claude Code