feat(embedder): support extra HTTP headers for OpenAI-compatible providers#694
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 17, 2026
Merged
Conversation
…iders
Add `extra_headers` field to `EmbeddingModelConfig` and `OpenAIDenseEmbedder`,
enabling custom HTTP headers (e.g., `HTTP-Referer`, `X-Title` required by
OpenRouter) to be passed as `default_headers` to the OpenAI client.
Also fix a dead-code bug in `OpenAIDenseEmbedder.__init__` where an
unconditional `raise ValueError("api_key is required")` prevented the
more nuanced check that allows missing `api_key` when `api_base` is set
(e.g., local OpenAI-compatible servers).
Closes volcengine#675
|
|
qin-ctx
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
extra_headerssupport toEmbeddingModelConfigandOpenAIDenseEmbedder, enabling custom HTTP headers (e.g.,HTTP-Referer,X-Titlerequired by OpenRouter) to be passed asdefault_headersto the OpenAI client.Also fix a dead-code bug where an unconditional
raise ValueError("api_key is required")prevented the more nuanced check that allows missingapi_keywhenapi_baseis set (e.g., local OpenAI-compatible servers).Type of Change
Testing
Related Issues
Checklist