Add a test to verify #80#83
Merged
graysonarts merged 9 commits intotableau:developmentfrom Sep 19, 2016
graysonarts:test-80-bugfix
Merged
Add a test to verify #80#83graysonarts merged 9 commits intotableau:developmentfrom graysonarts:test-80-bugfix
graysonarts merged 9 commits intotableau:developmentfrom
graysonarts:test-80-bugfix
Conversation
Updating README to include information for installing from pip
Releasing 0.2 to master
CLANotRequired
Release 0.3
* Scrub some strings in the test file so they don't include internal references * Updated some of the assets to be consistent in casing
t8y8
approved these changes
Sep 19, 2016
Contributor
t8y8
left a comment
t8y8
left a comment
There was a problem hiding this comment.
Looks good, though the PR has a bunch of other commits in it -- I trust you can fix that :)
Also for some reason pep8 is failing on one of the samples, is that related to this?
Contributor
Author
|
@t8y8 weird. I have pep8 running in my pre-commit hook, I don't know why it even let me check in. I'll get that fixed and merged. The other commits are a non-issue and already exist in development. It's just a weirdness with the squashing, etc. I'm starting to think we should maybe stop squashing on merge. |
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is picking up weird commits because of merging issues, but only the last commit is important.