gh-134043: use stackrefs for dict lookup in _PyObject_GetMethodStackRef#136412
Merged
kumaraditya303 merged 12 commits intopython:mainfrom Jul 28, 2025
Merged
gh-134043: use stackrefs for dict lookup in _PyObject_GetMethodStackRef#136412kumaraditya303 merged 12 commits intopython:mainfrom
_PyObject_GetMethodStackRef#136412kumaraditya303 merged 12 commits intopython:mainfrom
Conversation
colesbury
reviewed
Jul 8, 2025
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
- We should add a scaling benchmark to
ftscalingbench.pyfor the relevant access pattern - We probably need to avoid
Py_INCREF(dict)and that's going to require refactoring. You can safely avoidPy_INCREF(dict)in the same cases where_Py_dict_lookup_threadsafe_stackrefis relevant: when the dictionary keys areDICT_KEYS_UNICODE.
Contributor
|
This needs more refactoring - we can't load the keys twice like this because the condition might not hold. |
kumaraditya303
changed the title
_Py_dict_lookup_threadsafe_stackref for dict lookup in _PyObject_GetMethodStackRef_Py_dict_lookup_unicode_threadsafe_stackref for dict lookup in _PyObject_GetMethodStackRef
kumaraditya303
changed the title
_Py_dict_lookup_unicode_threadsafe_stackref for dict lookup in _PyObject_GetMethodStackRef_PyObject_GetMethodStackRef
colesbury
approved these changes
Jul 28, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…dStackRef` (python#136412) Co-authored-by: Sam Gross <colesbury@gmail.com>
Contributor
|
I'm going to backport this to 3.14 because it will simplify backporting #145826, which uses some of the same functions and macros. |
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 17, 2026
…etMethodStackRef` (pythonGH-136412) (cherry picked from commit cbe6ebe) Co-authored-by: Kumar Aditya <kumaraditya@python.org> Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 17, 2026
…etMethodStackRef` (pythonGH-136412) (cherry picked from commit cbe6ebe) Co-authored-by: Kumar Aditya <kumaraditya@python.org> Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-146077 is a backport of this pull request to the 3.14 branch. |
colesbury
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyObject_GetMethodand calling APIs #134043Changes
_PyObject_GetMethodStackRefto use_PyDict_GetMethodStackRefto avoid reference counting on deferred objects.