Skip to content

gh-120671: Fix as_fn_append CFLAGS#120822

Merged
vstinner merged 2 commits intopython:mainfrom
allsey87:main
Jun 25, 2024
Merged

gh-120671: Fix as_fn_append CFLAGS#120822
vstinner merged 2 commits intopython:mainfrom
allsey87:main

Conversation

@allsey87
Copy link
Contributor

@allsey87 allsey87 commented Jun 21, 2024

This fixes an issue with failing configure tests due to a missing space when appending to CFLAGS. @eli-schwartz tracked down the source of this bug as follows:

In commit 76d14fa (GH-29485), some code was refactored to be more compact and use more advanced autoconf tricks. In the process, it switched

AS_VAR_SET([XXX], ["$XXX other values"])

to

AS_VAR_APPEND([XXX], ["other values"])

This was a functional logic break, since it elided the space in between the existing and appended values -- and that space is mandatory for command-line flags stuffed into a variable.

The same problem occurred for LDFLAGS, but was silently fixed as a side effect of commit bb8b931 (GH-32229).

Resolves #120671

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing configure tests due to missing space

4 participants