gh-117142: ctypes: Migrate global vars to module state#117189
Merged
encukou merged 12 commits intopython:mainfrom Mar 29, 2024
neonene:ctypes_func
Merged
gh-117142: ctypes: Migrate global vars to module state#117189encukou merged 12 commits intopython:mainfrom neonene:ctypes_func
encukou merged 12 commits intopython:mainfrom
neonene:ctypes_func
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated PR from #117181, keeping global state access:
I think almost all diffs can be checked mechanically by C compilers except stylistic changes at 9342336.
Unfixed global variables:
Py_ffi_closure_alloc()Py_ffi_closure_free()free_listMove to module-state or
thunk type-state, used by:
_ctypes_alloc_callback()CThunkObject_dealloc()_pagesize_ctypes_get_fielddesc()initialized_ctypes_get_fielddesc()formattableCall_GetClassObject()context(unreachable)
Call_CanUnloadNow()context(unreachable)