gh-116333: Relax error string text expectations in SSL-related tests#116334
Merged
gpshead merged 5 commits intopython:mainfrom Mar 21, 2024
Merged
gh-116333: Relax error string text expectations in SSL-related tests#116334gpshead merged 5 commits intopython:mainfrom
gpshead merged 5 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As suggested here, this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython AWS-LC, but because AWS-LC is a fork of BoringSSL, it should increase compatibility with that library as well.
In addition to the error string relaxations, we also add some guards around the
tls-uniquechannel binding being used with TLSv1.3, as that feature (described in RFC 6929) is not defined for TLSv1.3.Call-outs
I've omitted a NEWS entry as this PR does not change anything for end users, and does not fully provide out-of-the box support for AWS-LC on its own.
Testing
system info