Importing TimelineItem from .com and creating matching docs#913
Importing TimelineItem from .com and creating matching docs#913shawnbot merged 4 commits intorelease-13.2.0from
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/orb2t9cwm |
shawnbot
left a comment
There was a problem hiding this comment.
This looks great! Let's queue it up for inclusion in 13.1.0, assuming we don't decide to move forward with 14.0.0.
shawnbot
left a comment
There was a problem hiding this comment.
@jonrohan it looks like this isn't being imported anywhere in the product bundle. I'm stumped as to why this actually works on the docs site, though. 🤔
Either way, it's not present in dist/primer.css from the most recently published canary release, so let's fix that before merging.
Great catch! I think it's because the Anyways, I added the import to "product" 74d0495. |
This PR adds the
TimelineItemcomponent that was recently added to github/github#120332I'm also documenting the new component on primer.style
TODO on dotcom
/cc @primer/ds-core