Merged
Conversation
|
This pull request is automatically deployed with Now. |
emplums
suggested changes
Aug 9, 2019
Contributor
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
Left a few comments! I just left some comments on the first example of the blankslate, but all the subsequent examples will need the same changes. Let me know if you have any questions! 💖
Co-Authored-By: Emily <emplums@github.com>
emplums
reviewed
Aug 9, 2019
Co-Authored-By: Emily <emplums@github.com>
This was referenced Dec 14, 2022
This was referenced Jan 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
blankslatecomponent and addresses #860 :border-0utilityRelated docs PRs:
primer/design #55
primer/design #58
Design:
Original design issue covers background and links to figma files.
Screenshot:
/cc @primer/ds-core