npm audit, dependency cleanup, delete script/check-links#797
Merged
shawnbot merged 5 commits intorelease-12.4.0from May 14, 2019
Merged
npm audit, dependency cleanup, delete script/check-links#797shawnbot merged 5 commits intorelease-12.4.0from
shawnbot merged 5 commits intorelease-12.4.0from
Conversation
shawnbot
requested review from
emplums and
jonrohan
and removed request for
simurai
emplums
approved these changes
May 14, 2019
Contributor
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
This looks good to me! Just left one question
| "@storybook/addon-viewport": "5.0.0", | ||
| "@storybook/react": "5.0.10", | ||
| "@storybook/addon-viewport": "5.0.11", | ||
| "@storybook/react": "5.0.11", |
Contributor
There was a problem hiding this comment.
Did you double check that storybook still runs fine? We just changed the storybook version but I can’t remember if we upgraded or downgraded it to make it work. Either way it would be great to check it’s all working fine if you haven’t already!
Contributor
Author
There was a problem hiding this comment.
Good call! Tested npm run start-storybook and it looks good on my machine:
This was referenced Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of things to resolve all but one (#796) vulnerability in our dependencies:
npm audit fix --forcescript/check-links, along with thebroken-link-checkerandchar-spinnerdependencies. We aren't running this script in CI right now, and it currently takes longer than I was willing to wait to run, so it's probably not working the way we want it to.script/check-relative-linksstill warns us about relative link paths that may be problematic, and if we have problems with broken links we should find another tool to detect them.