Merged
Conversation
Contributor
Author
|
Oof, well this was kind of tricky. My assumption in primer/stylelint-config#25 was that even with The result is that we still get all of the syntax and formatting rules, but we don't enforce "duplicate" selectors or classnames here because this is the source of those values. |
shawnbot
force-pushed
the
upgrade-stylelint-config
branch
from
4dd51b6 to
34cef02
Compare
shawnbot
force-pushed
the
upgrade-stylelint-config
branch
from
34cef02 to
3ad45c5
Compare
simurai
approved these changes
Apr 15, 2019
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
Looks good to me. 😝
I assume we need to add these rules to .stylelintrc.json because primer/css should be the only exception.
This was referenced Dec 14, 2022
This was referenced Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a placeholder for upgrading to
stylelint-config-primer@6.0.0once primer/stylelint-config#27 is ready. For now, let's see if the canary release of primer/stylelint-config#25 plays nicely.