Merged
Conversation
Contributor
Author
|
This appears to be working:
|
Contributor
Author
|
@ampinsk thanks, that's helpful! I'm going to revert that commit. |
…av-body" This reverts commit 43fd5ce.
emilybrick
approved these changes
Feb 20, 2019
Contributor
emilybrick
left a comment
There was a problem hiding this comment.
This lgtm! Once this ships I will remove the custom css I shamefully added here 😬
Contributor
Author
|
Welp, this turns out not to have been a good change after all. I tried a couple of things in the inspector and failed. I think getting the underline to overlap the border is going to require some more work, so in the meantime @ampinsk, are you okay with nixing the |
|
Yeah that's fine! It's a small detail so if it's a big headache we should nix it 😄 |
This was referenced Dec 16, 2022
This was referenced Dec 26, 2022
This was referenced Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





This makes some tweaks to the UnderlineNav component:
overflow-x: autofor horizontal scrolling, andoverflow-y: hiddento prevent vertical scrolling.Removes 1px clipping viamargin-bottom: -1pxon.UnderlineNav-body(because: why?)I'm requesting reviews from folks who have lots of experience with this component. Thanks!