Fix trailing slash error, upgrade to @primer/components v10#681
Closed
Fix trailing slash error, upgrade to @primer/components v10#681
Conversation
shawnbot
changed the title
shawnbot
force-pushed
the
fix-trailing-slash
branch
from
e012713 to
efefc3c
Compare
emplums
approved these changes
Feb 20, 2019
Contributor
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
This looks good to me, can we test it on primer.style/css before merging?
Contributor
|
Also! I agree I think it would be great to have in docs-components, I'll add it! |
Contributor
Author
|
Merged locally into #688. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for well-known Next.js issue with trailing slashes that cause the server to crash. The
redirectTrailingSlash()helper functiondocs/redirectis a drop-in replacement for the staticgetInitialProps()method of a custom error handler inpages/_error.js, and redirects if it gets a URL with a trailing slash to the "clean" URL without it.Or, as I've done in this PR, you can call it in your own
getInitialProps(context)(in whichcontexthasreq,res, anderrkeys) and extract the props you need for your custom error page.@emplums maybe this is worth including in our docs components?