Merged
Conversation
As tables are frequently used for comparing columns of numeric data (and have the ability to be right-aligned) we should make sure that we make it as easy as possibly. Toggling tabular numbers on givens you the ability to scan columns of numbers effectively, assuming the font supports it. If it doesn’t then this doesn’t have any effect, but is no worse than the current behaviour.
🦋 Changeset detectedLatest commit: 02bb222 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anandfresh
approved these changes
Oct 6, 2024
jonrohan
approved these changes
Nov 7, 2024
langermank
had a problem deploying
to
github-pages
GitHub Actions
Failure
langermank
approved these changes
Nov 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
As tables are frequently used for comparing columns of numeric data (and have the ability to be right-aligned) we should make sure that we make it as easy as possible. Toggling tabular numbers on, gives you the ability to scan columns of numbers effectively, assuming the font supports it.
Here’s an example from a recent PR without this CSS:
and with
font-variant: tabular-nums:What approach did you choose and why?
Flipping the switch with CSS is trivial. If the font doesn’t support this functionality then this doesn’t have any effect, but is no worse than the current behaviour.
What should reviewers focus on?
First commit to Primer. Please let me know if I’m doing anything wrong, especially with the changeset which is new to me.
Can these changes ship as is?