Merged
Conversation
🦋 Changeset detectedLatest commit: 648bda4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
approved these changes
Mar 28, 2023
Contributor
lukasoppermann
left a comment
lukasoppermann
left a comment
There was a problem hiding this comment.
From the code it looks great. 👍
I can not attest to the actual change, as I am not sure if/where this is used. But @langermank will probably be able to do that.
langermank
approved these changes
Mar 28, 2023
Contributor
langermank
left a comment
langermank
left a comment
There was a problem hiding this comment.
Its not goodbye, it's see you later (in dotcom) 🥲
jonrohan
approved these changes
Mar 28, 2023
Contributor
Author
Yep, this version will live on for a bit longer in https://github.com/github/github/pull/266944 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This removes
ActionList.What approach did you choose and why?
These styles are an earlier version of the
ActionListcomponent. A newer version was added later to PVC. The styles will be added to dotcom for the places that still rely on this version.What should reviewers focus on?
I removed also some Stories of other components that relied on the ActionList styles. Like NavList, Layout examples, TreeView. Is that ok? I assume the newer version is available in PVC's Lookbook.
Can these changes ship as is?