update default for flex wrap styles#2388
Merged
jonrohan merged 2 commits intoprimer:mainfrom Feb 22, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: b99ce07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
reviewed
Feb 22, 2023
Contributor
simurai
left a comment
There was a problem hiding this comment.
Is this change correct? Have I missed something in Primer or misunderstood the spec?
Yes, this looks correct. Thanks. 🙇
If this change is correct should the flex-nowrap line be first in the list in the documentation, as the default?
Usually the default is written first, so yeah, I would say moving .flex-nowrap to the top would be great. 👍
jonrohan
approved these changes
Feb 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
flex-wrap: no-wrapWhat approach did you choose and why?
no-wrapis the default value.d-flexin https://github.com/primer/css, but looking at how the CSS is applied in the browser it doesn't look like Primer setswrapon that class either, so it wouldn't be the default for an application using Primer (although our application may be behind in Primer versions)What should reviewers focus on?
flex-nowrapline be first in the list in the documentation, as the default?Can these changes ship as is?