Conversation
🦋 Changeset detectedLatest commit: 171b415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
changed the title
fieldset + label styles to base.scssform styles to base.scss
4 tasks
jonrohan
approved these changes
Dec 2, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This moves the
fieldsetlabel::placeholderstyles to
base.scss.What approach did you choose and why?
This is in support of primer/view_components#1638.
I think we shouldn't move all of the old form-control.scss styles to PVC. But specifically the
fieldset+::placeholderare still needed in PVC. So making them part ofbase.scssfeels like a good approach to make them more broadly available. They also don't use a class but instead use the element as selector. So having them inbase.scssseems a good place.What should reviewers focus on?
Any alternative? We could also move it to normalize.scss
Can these changes ship as is?