[Bug] Radio checked + focus state fixes#2314
Merged
langermank merged 3 commits intomainfrom Nov 17, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 6084b91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Nov 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Closes https://github.com/github/primer/issues/1489
Before:
👀 👀
CleanShot.2022-11-16.at.16.53.51.mp4
After:
CleanShot.2022-11-16.at.16.54.27.mp4
What approach did you choose and why?
Thanks to @vdepizzol for his lovely prototype! We're using a
borderinstead of a pseudo element to show the checked state.What should reviewers focus on?
This code lives in PVC so a bit tricky to test unless you open it in a devspace 😄
Can these changes ship as is?