Remove action list item animation#2284
Merged
simurai merged 2 commits intoprimer:mainfrom Oct 19, 2022
Merged
Conversation
Co-authored-by: Katie Langerman <langermank@github.com>
🦋 Changeset detectedLatest commit: 3a3d293 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
For more context, I worked with @koddsson on this one. Removing this animation solves a really strange bug for upcoming feature work, and since its low hanging fruit to remove it I think this is the best approach. We can investigate adding it back later if it becomes a priority. |
langermank
approved these changes
Oct 14, 2022
simurai
approved these changes
Oct 17, 2022
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
👍 on removing this animation. I assume 99.9% of users never really see it because it seems to be more like an easter egg where you have to press for a long time to see the scaling of the item.
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I want to fix a weird but with nested dialogs.
What approach did you choose and why?
I removed this somewhat unused animation since removing it fixes the issue. I'm happy to take commits to this PR if someone has a better alternative to my issue but since I think this animation isn't used a lot, I think this is fine.
Can these changes ship as is?