Fixing ActionList Item hover focus style#2255
Merged
langermank merged 3 commits intoprimer:mainfrom Sep 16, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: b4893c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
approved these changes
Sep 16, 2022
Contributor
Author
|
@langermank Thanks for adding the changeset! It doesn't look like I have permissions to merge, would you be able to help with getting the pr in? Do we just need a successful preview deploy now? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Show the focus ring around focused items with subitems while they are hovered. Fixes #2254
What approach did you choose and why?
Adding a not:(:focus-visible) to the rule that overrides the outline
Can these changes ship as is?