Moving segmented_control.css to primer_view_components#2208
Conversation
🦋 Changeset detectedLatest commit: 8d0161d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mperrotti
left a comment
mperrotti
left a comment
There was a problem hiding this comment.
I'm good with this, but I don't understand how we decide when styles should live in PCSS vs PVC. Could you point me to docs or help me understand?
Approval is assuming that this is in fact a patch and not a major release.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@primer/css": patch | |||
There was a problem hiding this comment.
Isn't this technically a breaking change?
There was a problem hiding this comment.
Technically you could say so, but I'm operating under this assumption:
We haven't begun to use this anywhere and it's not documented on the site yet, so I'm classifying this as a patch.
The code was added to this repository specifically for the view component which isn't complete yet.
It's a bit of an early test, I started an ADR here primer/view_components#1319 |
2 participants
What are you trying to accomplish?
I would like to move this component to Primer View Components. primer/view_components#1225
We haven't begun to use this anywhere and it's not documented on the site yet, so I'm classifying this as a patch.
Can these changes ship as is?