Merged
Conversation
🦋 Changeset detectedLatest commit: 8a8c3ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
approved these changes
Jul 25, 2022
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
It's always hard to tell if changing z-index will cause any side effects? 😅 But maybe fine for this case, considering the intention of .show-on-focus. Also the new AppFrame component sets that "Skip to content" button to 1000.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
When focused on the "Skip to content" button and not logged in, the button remains hidden.
Before:
After
What approach did you choose and why?
I increased the z-index to make it visible.
What should reviewers focus on?
All good 👍
Can these changes ship as is?