Merged
Conversation
🦋 Changeset detectedLatest commit: a31aa92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
approved these changes
May 19, 2022
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
This is a "private" bundle not currently included in the
coreindex created for testing purposes.
👍 As long as we don't output any variables, can't think of a concern. 🚢
Comment on lines
+5
to
+15
| // temporary import until primitives moves to core bundle | ||
| // importing the index from /css didn't play nice with Storybook | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/base/size/size.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/base/typography/typography.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/size/border.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/size/breakpoints.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/size/size-coarse.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/size/size-fine.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/size/size.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/size/viewport.css' | ||
| import '../../node_modules/@primer/primitives/tokens-v2-private/css/tokens/functional/typography/typography.css' |
Contributor
There was a problem hiding this comment.
At some point might nice to offer an .../tokens-v2-private/css/tokens/index.css to not have to update each file individually.
Contributor
Author
There was a problem hiding this comment.
100% agree 😂 I certainly will add that!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a "private" bundle not currently included in the
coreindex created for testing purposes. Tokens are available in Storybook and the docs site, and will be behind a feature flag in github/github.Can these changes ship as is?