Skip to content

Add mono font stack to <samp> tag#1876

Merged
simurai merged 7 commits intomainfrom
samp-mono-font-stack
Jan 26, 2022
Merged

Add mono font stack to <samp> tag#1876
simurai merged 7 commits intomainfrom
samp-mono-font-stack

Conversation

@vdepizzol
Copy link
Contributor

What are you trying to accomplish?

Fixes #1806.

Are additional changes needed?

  • No, this PR should be ok to ship as is. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 88c70bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vdepizzol vdepizzol requested a review from simurai January 13, 2022 20:39
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test and seems good to me. 👍

Also added an example to the docs:

Screen Shot 2022-01-18 at 15 11 44

@vdepizzol vdepizzol marked this pull request as ready for review January 25, 2022 18:30
@vdepizzol vdepizzol requested a review from a team as a code owner January 25, 2022 18:30
@simurai simurai enabled auto-merge (squash) January 26, 2022 06:06
@primer-css primer-css mentioned this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<samp> uses monospace instead of full monospace font stack

2 participants