Add Box--overlay styles + remove styleguide.css from docs#1754
Merged
Add Box--overlay styles + remove styleguide.css from docs#1754
Box--overlay styles + remove styleguide.css from docs#1754Conversation
🦋 Changeset detectedLatest commit: e032a98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Nov 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been loading the
https://github.com/site/assets/styleguide.cssbundle into the docs only because theBox--overlaycomponent is already documented but the styles live still in dotcom. So this PR...Box--overlaystyles from dotcomOverlaystyles are not included because I think they are not used anywhere.styleguide.cssbundle in the docsI think long term we should deprecate
Box--overlaybecause it looks like it's a variation of theBoxcomponent. But it probably should be an independent component like PRC'sDialog.Box--overlayis different:behaviors.css(as part of dotcom "components")frameworks.css(as part of PCSS "core")So we'll have to be on the lookout for regressions.
Part of https://github.com/github/primer/issues/393