Merged
Conversation
🦋 Changeset detectedLatest commit: c3702a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vdepizzol
approved these changes
Oct 26, 2021
simurai
approved these changes
Oct 27, 2021
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
👍
Just added a suggestion with short comments that it's a browser specific fix
Co-authored-by: simurai <simurai@github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Safari the text has an opacity that makes the text barely readable.
The fix is to use
-webkit-text-fill-colorandopacityto set those styles.This causes a bug in our developer token section on GitHub.
You can see in he screenshot below that in Safari the text is only slightly visible. You can barely see it but it's there.
This bug was reported in Slack
How to test this?
Snippet to test this 🐛
Before:
After:
Found this similar fix somewhere else: jgthms/bulma#2355
/cc @primer/css-reviewers