Skip to content

Set details overlay z-index to 111#1658

Merged
jonrohan merged 2 commits intomainfrom
make-sure-dialog-is-on-top-of-everything
Oct 5, 2021
Merged

Set details overlay z-index to 111#1658
jonrohan merged 2 commits intomainfrom
make-sure-dialog-is-on-top-of-everything

Conversation

@koddsson
Copy link
Contributor

@koddsson koddsson commented Oct 5, 2021

The sticky header in github/github is set to z-index: 110 and we want the overlay to be above that so I've set the z-index of it to 111.

See https://github.com/github/github/pull/195575.

/cc @primer/css-reviewers

@koddsson koddsson requested a review from a team as a code owner October 5, 2021 09:47
@koddsson koddsson requested a review from jonrohan October 5, 2021 09:47
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2021

🦋 Changeset detected

Latest commit: a35c4a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan merged commit 0ed0307 into main Oct 5, 2021
@jonrohan jonrohan deleted the make-sure-dialog-is-on-top-of-everything branch October 5, 2021 16:00
@primer-css primer-css mentioned this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants