Creating Header-input class for dark header inputs#1506
Conversation
🦋 Changeset detectedLatest commit: 4715037 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| .Header-input { | ||
| color: var(--color-header-text); | ||
| background-color: var(--color-header-search-bg); | ||
| border: $border-width $border-style var(--color-header-search-border); |
There was a problem hiding this comment.
@simurai These were the variables used in dotcom, but I think they're slated to be deprecated. Should we add to https://github.com/primer/primitives/blob/d607f36c4c974017d6974382f9bb88d6418211b8/data/colors_v2/vars/component_dark.ts#L23-L26 a border and inset variable? We could also have something for buttons maybe?
| .Header-input { | ||
| color: var(--color-header-text); | ||
| background-color: var(--color-header-search-bg); | ||
| border: $border-width $border-style var(--color-header-search-border); |
|
Ohh.. one more thing... does this input need a placeholder text color that is a bit dimmed? Currently on dotcom we use |
Fixes #1481
I added a
Header-inputclass to make search boxes in the header dark.