Make TimelineItem-badge--success ready for V2#1475
Merged
Conversation
🦋 Changeset detectedLatest commit: a2dcb0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
changed the title
btn-primary-text for TimelineItem-badge--successTimelineItem-badge--success ready for V2
Juliusschaeper
approved these changes
Jun 25, 2021
Contributor
Juliusschaeper
left a comment
Juliusschaeper
left a comment
There was a problem hiding this comment.
Makes sense to me 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
--color-text-whiteis dark in HC, but that causes other regressions.. so we decided to not have a replacement in Primer and deprecate--color-text-whiteand just add a hack to dotcom. See Slack.This PR replaces
--color-text-whitewith--color-fg-on-emphasisforTimelineItem-badge--success. As a fallback for V1--color-btn-primary-textis used.