Skip to content

set .btn-danger:disabled octicon color#1443

Merged
simurai merged 3 commits intoprimer:mainfrom
jdanyow:btn-danger-hover
Jun 8, 2021
Merged

set .btn-danger:disabled octicon color#1443
simurai merged 3 commits intoprimer:mainfrom
jdanyow:btn-danger-hover

Conversation

@jdanyow
Copy link
Contributor

@jdanyow jdanyow commented Jun 6, 2021

Override hover state's octicon color assignment.

Demo:
https://gist.run/?id=e36e29756f5d19e4cc94e88eed0022e1

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2021

🦋 Changeset detected

Latest commit: 5303f63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jdanyow jdanyow changed the title disable btn-danger hover effect when disabled Remove btn-danger hover effect when disabled Jun 7, 2021
@jdanyow jdanyow force-pushed the btn-danger-hover branch from 3b30c24 to 0862f7c Compare June 7, 2021 03:14

.octicon {
// stylelint-disable-next-line primer/colors
color: var(--color-btn-danger-disabled-text);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't see --color-btn-danger-disabled-**icon**... used the text variable

@jdanyow jdanyow closed this Jun 7, 2021
@jdanyow jdanyow reopened this Jun 7, 2021
@jdanyow
Copy link
Contributor Author

jdanyow commented Jun 7, 2021

closed accidentally 😵

@jdanyow jdanyow changed the title Remove btn-danger hover effect when disabled set .btn-danger:disabled octicon color Jun 7, 2021
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simurai simurai merged commit c65b5f9 into primer:main Jun 8, 2021
@primer-css primer-css mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants