Add common marketing utilities to primer/marketing#1254
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/BR1qBNY76uRMa6ipyZvK1751wNFq |
simurai
left a comment
There was a problem hiding this comment.
We're just about to release 16.0.0. Maybe tomorrow. So let's schedule this for 16.1.0.
Changes look good. Some of these might be handy as non-marketing utilities.. like the z-index and auto margin. I think we wanted to add them for a while already.
🦋 Changeset detectedLatest commit: 5d2f0be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
That sounds great ✨
Happy to move them out from the marketing bundle if that's the case 🙏 |
This PR adds a few common utilities to primer/marketing:
mt-n7,mb-8, etc), rather than stopping at 6hover-grow-mktganimation utility class, as well as an easing variable ($ease-mktg)m-auto), for centering elements withposition: absolute, andmt-autofor sticking things to the bottom for flex columns within a flex row or a fixed height elementz-1,z-2,z-3,z-n1,z-n2)width-autoandheight-auto, for resetting width/height of an image, after itswidthandheighthave been set in HTMLobject-fit-coverfor making an object cover its container https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit/cc @primer/ds-core