Add missing rounded-3 utility#1156
Merged
simurai merged 2 commits intoprimer:release-15.2.0from Sep 8, 2020
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/aqcneijd4 |
simurai
requested changes
Sep 3, 2020
Contributor
simurai
left a comment
There was a problem hiding this comment.
@esdraspavon Thanks for the addition. 🙇
Just realized we also have utility classes for each edge:
css/src/utilities/borders.scss
Lines 55 to 71 in c752b4e
Maybe we should use the $border-radius-[1-3] variables too instead of / 2 and * 2 so the values match?
Contributor
Author
|
@simurai np! sounds good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1154
/cc @primer/ds-core