Skip to content

Place search subnav example on new line#1155

Merged
simurai merged 2 commits intorelease-15.2.0from
subnav-doc-patch
Sep 8, 2020
Merged

Place search subnav example on new line#1155
simurai merged 2 commits intorelease-15.2.0from
subnav-doc-patch

Conversation

@ashygee
Copy link
Contributor

@ashygee ashygee commented Sep 2, 2020

Fixes break in search subnav component within docs.

  • Fixes:
Current Fix
image image

/cc @primer/ds-core

@ashygee ashygee requested a review from simurai September 2, 2020 17:56
@vercel
Copy link

vercel bot commented Sep 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/3pzkjcfy0
✅ Preview: https://primer-css-git-subnav-doc-patch.primer.vercel.app

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the intention is to use subnav-search-context next to subnav-links. But maybe fine to fix it here in the docs until we support a responsive version. 👍

@vercel vercel bot temporarily deployed to Preview September 3, 2020 04:41 Inactive
@simurai simurai changed the base branch from master to release-15.2.0 September 8, 2020 04:23
@simurai simurai merged commit 0f21d23 into release-15.2.0 Sep 8, 2020
@simurai simurai deleted the subnav-doc-patch branch September 8, 2020 04:23
@simurai simurai mentioned this pull request Sep 10, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants