Always show message about missing AMPF, when it's missing#22337
Open
NobodysNightmare wants to merge 1 commit intodevfrom
Open
Always show message about missing AMPF, when it's missing#22337NobodysNightmare wants to merge 1 commit intodevfrom
NobodysNightmare wants to merge 1 commit intodevfrom
Conversation
The previous check was overly specific. In case when the projectFolderHref was not null, but undefined, it would not correctly recognize the missing project folder. This caused the corresponding alert to be properly shown in the file-picker-modal, but not in the location-picker-modal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous check was overly specific. In case when the projectFolderHref was not null, but undefined, it would not correctly recognize the missing project folder.
This caused the corresponding alert to be properly shown in the file-picker-modal, but not in the location-picker-modal.
Ticket
https://community.openproject.org/wp/73122
Note
We are now also offering the user to upload the file to a location outside the AMPF. At first this surprised me, but I verified in a healthy project, that we never limit the location where a user can upload a file. The AMPF is just the default selection. Thus it's only consistent to also behave the same here and allow an upload anywhere, while showing a warning message.