Skip to content

child_process: remove unreachable execSync() code#9209

Merged
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:dead
Oct 25, 2016
Merged

child_process: remove unreachable execSync() code#9209
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:dead

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 20, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

Description of change

Code coverage showed that the execSync() variable inheritStderr was never set to the default value of true. This is because the default case is hit whenever normalizeExecArgs() returns an object without an options property. However, this can never be the case because normalizeExecArgs() unconditionally creates the options object. This commit removes the unreachable code.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants