http: fix no_proxy leading-dot suffix matching#62333
Open
watilde wants to merge 1 commit intonodejs:mainfrom
Open
http: fix no_proxy leading-dot suffix matching#62333watilde wants to merge 1 commit intonodejs:mainfrom
watilde wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62333 +/- ##
==========================================
- Coverage 91.64% 89.68% -1.96%
==========================================
Files 337 676 +339
Lines 140643 206579 +65936
Branches 21810 39563 +17753
==========================================
+ Hits 128893 185272 +56379
- Misses 11526 13439 +1913
- Partials 224 7868 +7644
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
NO_PROXYsuffix matching to prevent partial domain matchesThis PR improves
NO_PROXYlogic by ensuring suffix matches occur only on exact domains or subdomains. Previously, usingendsWith()caused false positives (e.g., myexample.com matching .example.com). This aligns with the expected domain boundary matching behavior.