zlib: fix use-after-free when reset() is called during write#62325
Open
mcollina wants to merge 1 commit intonodejs:mainfrom
Open
zlib: fix use-after-free when reset() is called during write#62325mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina wants to merge 1 commit intonodejs:mainfrom
Conversation
The Reset() method did not check the write_in_progress_ flag before resetting the compression stream. This allowed reset() to free the compression library's internal state while a worker thread was still using it during an async write, causing a use-after-free. Add a write_in_progress_ guard to Reset() that throws an error if a write is in progress, matching the existing pattern used by Close() and Write(). PR-URL: TODO Refs: https://hackerone.com/reports/3609132
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62325 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 676 676
Lines 206575 206582 +7
Branches 39547 39558 +11
=======================================
+ Hits 185261 185270 +9
- Misses 13443 13445 +2
+ Partials 7871 7867 -4
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Mar 18, 2026
jasnell
approved these changes
Mar 18, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Reset()method did not check thewrite_in_progress_flag before resetting the compression stream. This allowedreset()to free the compression library's internal state while a worker thread was still using it during an async write, causing a use-after-free.Add a
write_in_progress_guard toReset()that throws an error if a write is in progress, matching the existing pattern used byClose()andWrite().This does not fall within a threat model because it cannot be exploited from the outside.
Refs: https://hackerone.com/reports/3609132