benchmark: fix destructuring in dgram/single-buffer and update N convention in crypto#62084
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 16, 2026
Conversation
PR nodejs#59872 renamed the config key from `num` to `n` but did not update the destructuring in main(), leaving `{ num: n }` which resolves to undefined. This caused the benchmark to produce near-zero throughput since the send-batching logic never fires when n is undefined. Refs: nodejs#59872
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
RafaelGSS
approved these changes
Mar 3, 2026
lpinca
approved these changes
Mar 4, 2026
Contributor
Author
|
Hi @RafaelGSS @lpinca CI is green now. Is this ready to land? |
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9c1c08e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59872 renamed the config key from
numtonbut did not update the destructuring in main()Rename the
writesconfig parameter tonin three crypto benchmark files to align with the standard iteration-count conventionRefs: #59872
Refs: nodejs/performance#187