Skip to content

http2: refactor Http2Stream and inbound headers#16676

Closed
jasnell wants to merge 6 commits intonodejs:masterfrom
jasnell:http2-refactor-stream
Closed

http2: refactor Http2Stream and inbound headers#16676
jasnell wants to merge 6 commits intonodejs:masterfrom
jasnell:http2-refactor-stream

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Nov 2, 2017

  1. Eliminate pooling for Nghttp2Stream instances
  2. Use a MaybeStackBuffer for inbound headers
  3. Enforce a maximum number of headers per block
  4. Enforce a maximum number of header octets per block using MAX_HEADERS_LIST setting
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants