Revert "url: const-ify APIs, and pass URL by ref"#15723
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "url: const-ify APIs, and pass URL by ref"#15723BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit af6af08.
Ref #15615 (comment)
This results in build errors on Windows and it is now to late to rebase to get rid of this commit.
To have one option of solving this fast I open this revert.
@sam-github or anyone else - if there is a nicer fix that could land fast as well, I think that would be the preferred way instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url