N-API: Remove reference to node internals#13892

Closed

gabrielschulhof wants to merge 1 commit intonodejs:masterfrom

gabrielschulhof:avoid-node-internals

Contributor

gabrielschulhof commented Jun 23, 2017

We must keep src/node_api.cc free of node internals because it must
build cleanly outside of node as well - for example in node_addon_api.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis requested changes

jasnell jasnell approved these changes

cjihrig cjihrig approved these changes

mhdawson mhdawson approved these changes

+2 more reviewers

digitalinfinity digitalinfinity approved these changes

jasongin jasongin approved these changes

Labels