failing known-issues tests

[Fishrock123]

There were no (visible?) known-issues ci jobs run yet so I ran one. there seems to be quite a few failures...

https://ci.nodejs.org/job/node-test-known-issues/3/

It is possible some of these are due to platform-specific tests, would there be a better way to denote those? Maybe produce tap skipped output?

cc @nodejs/testing @cjihrig

[cjihrig]

All of the failures are:

=== release test-stdout-buffer-flush-on-exit [negative] ===
Path: known_issues/test-stdout-buffer-flush-on-exit
Command: out/Release/node /home/iojs/build/workspace/node-test-known-issues/nodes/debian8-64/test/known_issues/test-stdout-buffer-flush-on-exit.js

Ping @Trott from 33c27f8#diff-bee0ad67db456c74881851e227542dbb. There doesn't seem to be a lot of consistency among platforms on this one.

[Trott]

Argh, looks like it's actually flaky. Sometimes it passes on a platform and sometimes it fails. Will tinker a bit in hopes of making it reliable...

[Trott]

I've got it failing-as-expected everywhere but Windows. There doesn't seem to be a way to use the known_issues.status file in this situation (where you are expecting failure) so I either need to hack test.py for it or else add some code to bail out of the test, but then someone has to remember to remove the bail out code when the test is moved to parallel.

[Trott]

Oh, SKIP seemed to get the job done. PR coming soon.

[orangemocha]

In the status files there also used to be support for a FAIL status, though I am not sure if it was fully ported from the v8 test runner.

On May 4, 2016, at 02:03, Rich Trott <notifications@github.commailto:notifications@github.com> wrote:

Oh, SKIP seemed to get the job done. PR coming soon.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/6527#issuecomment-216703284