v14.17.5 fails to build if configured with --shared-cares

[asavah]

Version

v14.17.5

Platform

Linux kross-1910 5.11.0-25-generic #27-Ubuntu SMP Fri Jul 9 23:06:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

configure node with --shared-cares which most linux distros use, try building it

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

Clean build

What do you see instead?

Build failure

In file included from ../src/cares_wrap.cc:25:
../src/cares_wrap.h:25:11: fatal error: ares_nameser.h: No such file or directory
   25 | # include <ares_nameser.h>
      |           ^~~~~~~~~~~~~~~~

Additional information

ares_nameser.h is a private header which is not installed to the system include dir.

4923b59 shouldn't have landed in LTS in its current state ...

[dilyanpalauzov]

The same applies to v16.8.0 . libcares does not install ares_nameser.h , so the declarations from this file are not public.

[dilyanpalauzov]

I see now at c-ares/c-ares@b9845b8 that the headers are now installed.

[richardlau]

This should now be fixed with the c-ares 1.18.1 in Node.js 12, 14, 16 and 17.