Add Buffer#includes()

[sindresorhus]

For convenience, code clarity, and parity with TypedArray. See TypedArray#includes().

The includes() method determines whether a typed array includes a certain element, returning true or false as appropriate.

[targos]

TypedArray#includes and Array#includes are not shipped in V8 yet.
When it happens, buffers will have the method. You can test it with the harmony flag:

% node -v
v5.0.0-rc.1
% node --harmony
> var buffer = new Buffer(1).fill(1)
undefined
> buffer.includes(1)
true

[trevnorris]

Though we might want to override it. v8's implementation (following the spec) is restrictive and slow. e.g. indexOf(), fill(). Instead, to have feature parity with current Buffer API's we should consider our own impl that accepts multi-char strings, etc.

[targos]

@trevnorris good point! Then we can just wrap it around indexOf.

[trevnorris]

Oh yeah. Good call. Easy PR for the taking.

[sindresorhus]

I made a polyfill: https://github.com/sindresorhus/buffer-includes

[rodmachen]

Just added a PR to implement this.

#3568

[Fishrock123]

PR is #3567