src: add node::url::URL::href() method

[alexkozy]

Is your feature request related to a problem? Please describe.
I need to get href based on instance of URL object in native code.

Describe the solution you'd like
I can use href() method that is added in addition to existing getters.

[addaleax]

@nodejs/url

[devsnek]

the url serializer is written in js, so i'm not 100% sure if this is possible without a lot of code duplication

[TimothyGu]

@devsnek Yeah my guess is that we will have to duplicate. That's fine though, as we already have a duplicated URL class in C++ anyway.

[tigercosmos]

Are there any specs for URL::href()?

[tigercosmos]

I am not sure if is this one
https://url.spec.whatwg.org/#dom-url-href

[TimothyGu]

@tigercosmos Yes! You can even look at how lib/internal/url.js implements it in JavaScript, and just duplicate that logic in C++.

[WaleedAshraf]

Hi @ak239
I think you can use toString() also?
They both return the same result.

[stropitek]

I'm taking over this issue

[addaleax]

@stropitek As @WaleedAshraf commented, this might not be necessary since ToString() also works… just as a heads up, so you don’t do unnecessary work :)

[davesters]

May be worth it to dig deeper to verify if ToString() actually exists and works in C++.

If it does to remove this TODO and update to use the ToString() function.
https://github.com/ak239/node/blob/master/src/inspector_agent.cc#L622