BSD-x86 config missing after OpenSSL 1.1.0h import

[bradleythughes]

• Version: v10.0.0
• Platform: FreeBSD
• Subsystem: deps/openssl

After the OpenSSL 1.1.0h import, deps/openssl/config/Makefile was added with a list of supported architectures for building with ASM support. However, the ARCHS list (errantly?) omits BSD-x86 from the list:

https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/Makefile#L12

The BSD-x86 arch is listed in the README and header files, however, and trying to build Node.js v10.0.0 on FreeBSD i386 fails due to the missing BSD-x86/* headers.

https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/README.md
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/opensslconf_asm.h#L39
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/opensslconf_asm.h#L112
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/opensslconf_no-asm.h#L20

[bnoordhuis]

Want to submit a pull request? I have no way to test so I'd be committing blindly if I just checked in the file.

[bradleythughes]

Yes, I do, but unfortunately deps/openssl/config/Makefile is Linux specific, so I will need some time to get it running on FreeBSD to regenerate the archs before I can create a PR.

[Trott]

Is this still an issue? (I'm guessing yes, but it's been inactive long enough that maybe it got fixed but the issue was never closed?)

[bradleythughes]

Yes, it is still an issue. The FreeBSD port/package patches the build to use a no-asm build on i386 as a workaround. I have yet to invest the time in a proper solution.

[bnoordhuis]

You know, I'd be okay with adding BSD-x86 to the list and just regenerating everything. It's not a supported platform so if it works, cool, and if it doesn't, it's not a regression.

[bnoordhuis]

@bradleythughes Perhaps you can test #28806?