- Version: *
- Platform: *
- Subsystem: test
Ref: #13623 (comment)
as reported by @cjihrig:
common.expectsError() is subtly broken. It relies on instanceof to check the error type. So a TypeError is an instance of Error, which is why this passed. The simplest fix might be to check error.constructor inside of common.expectsError(). But that will require updating a bunch of tests because we're now using custom errors all over the place.