async-hooks/test-fseventwrap - Flaky on AIX

[mhdawson]

• Version: Master
• Platform: AIX
• Subsystem: fs

Looks like test-fseventwrap fails intermitently on AIX:

https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/6463/console

not ok 13 async-hooks/test-fseventwrap
  ---
  duration_ms: 0.185
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED (Signal: 11)
  ...

I believe I've seen it on at least one other PR unrelated to fswatch/asyncwrap.

@gireeshpunathil can you take a look.

[mhdawson]

@nodejs/platform-aix

[refack]

Seen again https://ci.nodejs.org/job/node-test-commit-aix/6442/nodes=aix61-ppc64/

[refack]

/cc @nodejs/async_hooks

[gireeshpunathil]

Recreated (intermittent) the crash in the compiler:

#0  0x000000010050e3d4 in v8::internal::AstValueFactory::GetString(unsigned int, bool, v8::internal::Vector<unsigned char const>) ()
(gdb) where
#0  0x000000010050e3d4 in v8::internal::AstValueFactory::GetString(unsigned int, bool, v8::internal::Vector<unsigned char const>) ()
#1  0x000000010050e9e8 in v8::internal::AstValueFactory::GetOneByteStringInternal(v8::internal::Vector<unsigned char const>) ()
#2  0x000000010050e9e8 in v8::internal::AstValueFactory::GetOneByteStringInternal(v8::internal::Vector<unsigned char const>) ()
#3  0x000000010052a7ec in v8::internal::Scanner::IsDuplicateSymbol(v8::internal::DuplicateFinder*, v8::internal::AstValueFactory*) const ()
#4  0x0000000100529b5c in v8::internal::ParserBase<v8::internal::Parser>::ParseAndClassifyIdentifier(bool*)
    ()
#5  0x000000010052895c in v8::internal::ParserBase<v8::internal::Parser>::ParsePrimaryExpression(bool*, bool*) ()
#6  0x0000000100528040 in v8::internal::ParserBase<v8::internal::Parser>::ParseFormalParameter(v8::internal::ParserFormalParameters*, bool*) ()
#7  0x000000010055fc24 in v8::internal::ParserBase<v8::internal::Parser>::ParseFormalParameterList(v8::internal::ParserFormalParameters*, bool*) ()
#8  0x000000010055f2d8 in v8::internal::Parser::ParseFunction(v8::internal::AstRawString const*, int, v8::internal::FunctionKind, v8::internal::FunctionLiteral::FunctionType, v8::internal::DeclarationScope*, int*, int*, bool*, int*, bool*) ()
#9  0x000000010055e234 in v8::internal::Parser::ParseFunctionLiteral(v8::internal::AstRawString const*, v8::internal::Scanner::Location, v8::internal::FunctionNameValidity, v8::internal::FunctionKind, int, v8::internal::FunctionLiteral::FunctionType, v8::internal::LanguageMode, bool*) ()
#10 0x00000001005271e8 in v8::internal::Parser::DoParseFunction(v8::internal::ParseInfo*, v8::internal::AstRawString const*) ()
#11 0x000000010050c4e8 in v8::internal::Parser::ParseFunction(v8::internal::Isolate*, v8::internal::ParseInfo*) ()
#12 0x000000010050b878 in v8::internal::parsing::ParseFunction(v8::internal::ParseInfo*, v8::internal::Isolate*, bool) ()
#13 0x00000001004bf730 in v8::internal::(anonymous namespace)::GetUnoptimizedCode(v8::internal::CompilationInf---Type <return> to continue, or q <return> to quit---
o*, v8::internal::Compiler::ConcurrencyMode) ()
#14 0x00000001004c1ef4 in v8::internal::(anonymous namespace)::GetLazyCode(v8::internal::Handle<v8::internal::JSFunction>) ()
#15 0x00000001001b5108 in v8::internal::Compiler::Compile(v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Compiler::ClearExceptionFlag) ()
#16 0x0000000100c7f920 in v8::internal::Runtime_CompileLazy(int, v8::internal::Object**, v8::internal::Isolate*) ()
#17 0x07000000001845f4 in ?? ()

[Trott]

Still a thing...

https://ci.nodejs.org/job/node-test-commit-aix/6522/nodes=aix61-ppc64/console

not ok 13 async-hooks/test-fseventwrap
  ---
  duration_ms: 0.173
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED (Signal: 11)

[gireeshpunathil]

there are three mutually exclusive issues:

1. the test case test-fseventwrap.js employs directory watch, which is not supported in AIX
2. AIX fails to build in debug mode: throws linker error:
   ld: 0711-317 ERROR: Undefined symbol: vtable for v8::base::PosixTimezoneCache
3. Crash in v8::internal::AstValueFactory::GetString

Debugging item 3. at the moment.

[trevnorris]

@gireeshpunathil

1. the test case test-fseventwrap.js employs directory watch, which is not supported in AIX

Why would only this test fail when there are other tests that check directory watch.

[gireeshpunathil]

@trevnorris - this test did not fail due to (1) above (yet) - the test progress is masked off by the crash