Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Copilot agent host integration so the Copilot CLI subprocess can use VS Code’s shipped ripgrep instead of relying on a Copilot-bundled ripgrep being copied into the SDK during packaging.
Changes:
- Add
@vscode/ripgrep’s binary directory to the Copilot CLI subprocessPATH(and setUSE_BUILTIN_RIPGREP=0) in the agent host. - Stop copying ripgrep into
@github/copilot/...during packaging; keep only node-pty prebuild copying. - Remove macOS universal-app and Mach-O verification special-casing for Copilot’s ripgrep directory.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/copilot/copilotAgent.ts | Injects VS Code’s ripgrep location into the Copilot CLI subprocess environment. |
| build/gulpfile.vscode.ts | Removes packaging-time copying of ripgrep into the Copilot SDK layout. |
| build/darwin/verify-macho.ts | Stops skipping Copilot ripgrep paths during Mach-O architecture validation. |
| build/darwin/create-universal-app.ts | Removes cross-copying and arch-file patterns for Copilot ripgrep in universal app creation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.